chore(metrics): remove dead sparse helpers and MetricEvent::with_timestamp#1338
Closed
jwiegley wants to merge 1 commit into
Closed
chore(metrics): remove dead sparse helpers and MetricEvent::with_timestamp#1338jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced May 11, 2026
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
b7834ac to
b0224cf
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
2 times, most recently
from
2c4e995 to
8bbf005
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
2 times, most recently
from
6fdf6ed to
fcd41cc
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
fcd41cc to
ee48db8
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
from
21c1a42 to
d13815d
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
ee48db8 to
6a6b31c
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
from
d13815d to
6b04ac1
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
6a6b31c to
c6b20e3
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
2 times, most recently
from
4cfe337 to
f1a31d0
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
c6b20e3 to
bafdda4
Compare
…stamp sparse_get_f64 and sparse_get_vec_u64 in pos_encoded.rs had no callers outside their own tests — no metric field uses f64 or Vec<u64> encoding. MetricEvent::with_timestamp in types.rs was similarly only exercised by its own unit test; production metrics are constructed via MetricEvent::new. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
bafdda4 to
d5a507e
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
from
f1a31d0 to
5487d5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sparse_get_f64 and sparse_get_vec_u64 had no callers outside their own tests — no metric field uses f64 or Vec encoding. MetricEvent::with_timestamp was similarly only tested internally; production metrics use MetricEvent::new.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code