chore(auth,config,mdm): remove dead initialization and utility methods#1339
Closed
jwiegley wants to merge 1 commit into
Closed
chore(auth,config,mdm): remove dead initialization and utility methods#1339jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced May 11, 2026
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
b7834ac to
b0224cf
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
7fdd403 to
9147d02
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
b0224cf to
6fdf6ed
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
9147d02 to
8780647
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
6fdf6ed to
fcd41cc
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
8780647 to
2a9a1ca
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
fcd41cc to
ee48db8
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
2a9a1ca to
a085b70
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
ee48db8 to
6a6b31c
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
a085b70 to
32eb469
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
6a6b31c to
c6b20e3
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
32eb469 to
c46f342
Compare
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
c6b20e3 to
bafdda4
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
c46f342 to
3d55c11
Compare
- CredentialStore::has_credentials: zero callers outside its own tests - Config::init: redundant with the lazy Config::get() initializer; nothing called it explicitly - FeatureFlags::from_env and from_deserializable: dead since from_env_and_file became the single production entry point - Spinner::update_message, wait_for, skipped: UI helpers with zero callers; the spinner is driven solely via start/finish in production Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/metrics-sparse-cleanup
branch
from
bafdda4 to
d5a507e
Compare
jwiegley
force-pushed
the
dc/auth-config-mdm-cleanup
branch
from
3d55c11 to
929bf60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CredentialStore::has_credentials: zero callers outside its own tests. Config::init: redundant with the lazy Config::get() initializer. FeatureFlags::from_env and from_deserializable: dead since from_env_and_file became the sole production entry point. Spinner::update_message, wait_for, skipped: zero callers in production.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code